r? @BoxyUwU

rustbot has assigned @BoxyUwU.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

Looks like this triggers a new unused warning in the stdlib? Is this intentional? We probably should crater this if so.

@bors2 try
@rustbot author

Reminder, once the PR becomes ready for a review, use @rustbot ready.

⌛ Trying commit 5feb92e with merge 8c500c7…

To cancel the try build, run the command @bors try cancel.

Looks like this triggers a new unused warning in the stdlib? Is this intentional?

Yes, some new unused items can be detected now.
It shouldn't be common though.

☀️ Try build successful (CI)
Build commit: 8c500c7 (8c500c7cefd54fd11d57295f3771d576be9ee415, parent: 2886b36df4a646dd8d82fb65bf0c9d8d96c1f71a)

We probably should crater this if so.

@craterbot check

👌 Experiment pr-145113 created and queued.
🤖 Automatically detected try build 8c500c7
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

🚧 Experiment pr-145113 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

🎉 Experiment pr-145113 is completed!
📊 15 regressed and 3 fixed (679020 total)
📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

🎉 Experiment pr-145113 is completed! 📊 15 regressed and 3 fixed (679020 total) 📰 Open the summary report.

⚠️ If you notice any spurious failure please add them to the denylist! ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

A few new unused import lints, as expected.
@rustbot ready

I have no idea how to build rust-analyzer to reproduce those errors, ./x t rust-analyzer does not show them.

x test does not yet test and built the whole of rust-analyzer, so you need to x check it

ping @compiler-errors

Is there any way to write a test for this? The effect of this that we expect for users is just some new unused import warnings, right?

Ah, the test for preludes was already merged as a part of #144793 (tests/ui/resolve/extern-prelude-speculative.rs).

The removed unused imports across the repo are mostly like this:

#[macro_export]
macro_rules! mac { () => {} }

fn main() {
    use crate::mac; // unused, `mac` as `macro_rules!` is already in scope and has higher priority
    
    mac!();
}

The effect of this that we expect for users is just some new unused import warnings, right?

Yes.

r? compiler

r? compiler

I've added #145113 (comment) to test cases in addition to tests/ui/resolve/extern-prelude-speculative.rs.
@rustbot ready

This PR was rebased onto a different master commit. Here's a range-diff highlighting what actually changed.

Rebasing is a normal part of keeping PRs up to date, so no action is needed—this note is just to help reviewers.